-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/settings #27
Open
m4gpi
wants to merge
21
commits into
master
Choose a base branch
from
feature/settings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/settings #27
Changes from 14 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
2d98ad2
grab helper methods from patchbay
2181369
build basic view
370609b
port in patch-profile code
c14be60
refactor into Cropper component and line up image sizes
bac5cdc
justify buttons to bottom
608c122
tidy up layout
e5b0d1d
add title to cog on hover
0e4d28f
align styling of inputs with rest of app
7d9dd7b
lint
96a972a
query for about messages and show a warning icon is nothing is published
0521a17
add local peers
505d220
add tabs inside settings area with account and network options
7804f4d
make crystalShow a component, not a page
d6b9f6c
tidy up the css and reenable requests
f2357f9
some stylistic changes
394693d
correct stylin on settings show account edit
eb2e452
standardise styling more!
9245539
remove rouge console.log
3b42500
correct height
3542abe
rename show to edit
b7d2505
missing edit
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mixmix any idea why reduce wouldn't be working here? Trying to just fo a count of the number of about messages. To be honest, what I really want is to grab the first
about
message, and terminate the stream if we find one. This is to be able to show a warning to the user to notify them that they haven't added any personal information yet.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KGibb8 I'm gonna skip to your question about what you'd like to query (because don't know about reduce easily)
limit: 1
and it will quite out after first match is foundreverse: true
because that will give you the most recent about messagename
which is a string of length > 2 ? you might need to not uselimit: 1
and instead use a drain and a http://pull-stream.github.io/#pull-abortable to cancel once you've confirmed some things a little more carefully in the drain