-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Add assertionWithLazyOperator #18
base: main
Are you sure you want to change the base?
Conversation
@@ -70,13 +70,7 @@ if (globsOrNames.some((item) => item.includes("*"))) { | |||
globsOrNames.map( | |||
(globOrName) => | |||
new Promise((resolve, reject) => { | |||
glob(globOrName, (err, files) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently this callback variant does not exist anymore in the version 10.3.10 (cf: https://github.com/isaacs/node-glob?tab=readme-ov-file#globpattern-string--string-options-globoptions--promisestring--path ). Only promise and sync options exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just posted this in the issues: #19 maybe should have checked PR first
the |
The thing is, the |
For context, we're replacing some We use the printer function because we are working with a document model; the simple object diff doesn't provide enough context for changes deep in the tree. In the absence of a printer function, we have to render those details into the string description which can be expensive. Would you rather we add an assertion with a printer function? |
Closes #17