Enhance UtxoSelectionStrategy for HDWallet (WIP) #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satran004
changed the title
…r indexToScan in HDWalletAddressIterator
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Changes / Enhancements:
Address:
A new constructor to set the derivation path for the address. It's an optional property and is useful for HD Wallet implementation.
UtxoSupplier:
A new method
isUsedAddress(address)which returns whether the address has been used in at least one transaction. This is required to scan used addresses in HD wallet implementation.UtxoSelectionStrategy:
A new
selectUtxos()method which takes anAddressIteratorinstead of a single address. For HD Wallets, there is anHDWalletAddressIteratorwhich provides addresses at different indexes.Other changes and refactoring have been made to include the above modifications.
Known Limitation:
The Wallet interface works with all non-script transactions. For ScriptTx, a few additional changes are required to handle cases when the wallet is used as a fee payer or collateral payer wallet. These will be addressed in another PR.