fix client-version fallback not handling channel errors (#4378)

bloxstraplabs · Jan 23, 2025 · 4785464 · 4785464
1 parent 5d1aa50
commit 4785464
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/Bloxstrap/RobloxInterfaces/Deployment.cs b/Bloxstrap/RobloxInterfaces/Deployment.cs
@@ -176,7 +176,15 @@ public static async Task<ClientVersion> GetInfo(string? channel = null)
                     App.Logger.WriteLine(LOG_IDENT, "Failed to contact clientsettingscdn! Falling back to clientsettings...");
                     App.Logger.WriteException(LOG_IDENT, ex);
 
-                    clientVersion = await Http.GetJson<ClientVersion>("https://clientsettings.roblox.com" + path);
+                    try
+                    {
+                        clientVersion = await Http.GetJson<ClientVersion>("https://clientsettings.roblox.com" + path);
+                    }
+                    catch (HttpRequestException httpEx)
+                    when (!isDefaultChannel && BadChannelCodes.Contains(httpEx.StatusCode))
+                    {
+                        throw new InvalidChannelException(httpEx.StatusCode);
+                    }
                 }
 
                 // check if channel is behind LIVE