Skip to content
This repository has been archived by the owner on Dec 1, 2017. It is now read-only.

Encounter participant missing #154

Closed

Conversation

anmolagar
Copy link
Contributor

@sankarravi Please consider merging this pull request against issue no #153

work: performer_phone
},
address: performer_addr
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anmolagar You're parsing data from encompassingEncounter/encounterParticipant but you're not actually using any of those parsed fields – this just outputs the data that's coming out of documentationOf/performer and is currently output in documentation_of.

It looks like very few of the samples are using the encounterParticipant field. Are you running into samples where this is important data?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, encounterParticipant is important data in our use case.

@anmolagar anmolagar force-pushed the encounterParticipant_missing branch from 3d01927 to afca54f Compare November 18, 2015 09:12
@anmolagar
Copy link
Contributor Author

@sankarravi
I have updated the pull request to rectify the issues you found earlier.
However, there is a failing test case in case of 'nist'. It seems like there are two different 'nist' xmls at different locations which are conflicting.
Both the nist files expects the output as fixtures\json\nist_ccda_expected_output.json while one has encounterParticipant and other do not.
I was not able to rectify this issue, please help me out here.

@anmolagar
Copy link
Contributor Author

@sankarravi
Please help me fix the test cases here. here is a failing test case in case of 'nist'. It seems like there are two different 'nist' xmls at different locations which are conflicting.
Both the nist files expects the output as fixtures\json\nist_ccda_expected_output.json while one has encounterParticipant and other do not.
I was not able to rectify this issue, please help me out here.

@sankarravi
Copy link
Member

@anmolagar There is only one NIST file used for the tests. The test you are failing is the NIST JSON -> CCDA -> JSON test, which verifies that the parser and generator support the same data. To fix this test, you'll need to add support to ccda_template.ejs for outputting an encounterParticipant.

@anmolagar anmolagar force-pushed the encounterParticipant_missing branch from afca54f to 5dd8262 Compare December 17, 2015 13:00
@anmolagar anmolagar force-pushed the encounterParticipant_missing branch from 5dd8262 to ff4719b Compare December 18, 2015 05:06
@anmolagar
Copy link
Contributor Author

@sankarravi, even after adding code to ccda_template.ejs, i am getting test failure.
Looking for some help here as i am not an ejs expert.

@anmolagar
Copy link
Contributor Author

@sankarravi
Hi Ravi, any changes in ccda_template.ejs is not helping me to resolve the test case issue. Can you please have a look at this?
If i understand it correctly, there are two nist files \bower_components\sample_ccdas\NIST Samples\CCDA_CCD_b1_InPatient_v2.xml and \spec\javascripts\fixtures\ccda\nist_expected_ccda.xml
for both of which expected output is same \spec\javascripts\fixtures\json\nist_ccda_expected_output.json, looks like, this is what is causing the problem.

@sankarravi sankarravi closed this Jan 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants