Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Remove config yaml #1225

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

joelN123
Copy link
Contributor

@joelN123 joelN123 commented Oct 16, 2020

The config.yaml file contains the same information as the config.py file. So, it is possible to remove the code related to config.yaml. This is stated in #1224. A second point is that loading the config.yaml can cause error #1110. So this PR would also resolve that problem.

After modifying the code, I tried training, exporting, and converting. All seemed to run fine. No config.yaml appears.

p.s. in the save_yaml function, I just remove the config.yaml part, not the meta.yaml part.

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Oct 16, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada, tfujiwar, a-hanamoto

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

Copy link
Member

@kchygoe kchygoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz update

tests/unit/test_configs.py Outdated Show resolved Hide resolved
blueoil/utils/config.py Outdated Show resolved Hide resolved
@joelN123 joelN123 requested review from iizukak and kchygoe October 19, 2020 07:23
Copy link
Member

@kchygoe kchygoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the changes
(plz check the specification change with the owner)

@joelN123
Copy link
Contributor Author

@iizukak how do you think about these changes?
One possible contentious point is that the save_yaml function remains, for saving the meta.yaml. I think that meta file may be important for running certain kinds of demo https://github.com/blue-oil/blueoil/blob/master/docs/usage/export.md so it's better to keep it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants