-
Notifications
You must be signed in to change notification settings - Fork 86
Remove config yaml #1225
base: master
Are you sure you want to change the base?
Remove config yaml #1225
Conversation
This PR needs Approvals as follows.
Please choose reviewers and requet reviews! Click to see how to approve each reviewsYou can approve this PR by triggered comments as follows.
See all trigger commentsPlease replace [Target] to review target
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the changes
(plz check the specification change with the owner)
@iizukak how do you think about these changes? |
The
config.yaml
file contains the same information as theconfig.py
file. So, it is possible to remove the code related toconfig.yaml
. This is stated in #1224. A second point is that loading theconfig.yaml
can cause error #1110. So this PR would also resolve that problem.After modifying the code, I tried training, exporting, and converting. All seemed to run fine. No
config.yaml
appears.p.s. in the
save_yaml
function, I just remove theconfig.yaml
part, not themeta.yaml
part.