-
Notifications
You must be signed in to change notification settings - Fork 86
Refactored operators. (#532) #880
base: master
Are you sure you want to change the base?
Conversation
This PR needs Approvals as follows.
Please choose reviewers and requet reviews! Click to see how to approve each reviewsYou can approve this PR by triggered comments as follows.
See all trigger commentsPlease replace [Target] to review target
|
@yd8534976 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ownership Approval
LGTM. Could you resolve conflicts? @ed728 |
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# ============================================================================= | ||
from .base import Operator, Conv, Pool, MaxPool, AveragePool, Add, Gemm, Mul,\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.python.org/dev/peps/pep-0008/#id19
The preferred way of wrapping long lines is by using Python's implied line continuation inside parentheses, brackets and braces. Long lines can be broken over multiple lines by wrapping expressions in parentheses. These should be used in preference to using a backslash for line continuation.
|
1 similar comment
|
What this patch does to fix the issue.
Moves
operators.py
tobase/operators.py
and creates an__init__.py
for the directory. In later PRs Operators will be gradually split into files.Link to any relevant issues or pull requests.
This is the first is based on a previous PR(#642). That one is too large so it has been split, this is the first part. The other parts are mostly ready and will be made into PRs as soon as this one is done.
The next commits start factoring operators. The next are the branches below:
https://github.com/ed728/blueoil/tree/ops3
https://github.com/ed728/blueoil/tree/ops4
These will be made into PRs when this one has been merged.
Testing.
Manual and CI. Mainly to make sure imports in all modules don't break. Some Arm-related issues did come up but seems to be fine now.