Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested pulls #17

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

KathrynPanger
Copy link

Issue fixed. Data can now be pulled for all sub-regions of a larger region if geography is specified correctly. Also added the ability to get all variables for a group rather than request each variable individually from the api.

@jjackson12
Copy link
Collaborator

Some tests aren't passing -- want to get those passing before merging. I pushed some edits to fix some basic ones, but a few things still need to be resolved:

  1. We're relying on a local "config.py" file to insert the Census API key -- but without that errors pass without explanation. Ideally there's a better solution here for ensuring this is done on setup, but at least we could throw some helpful errors if that file is not present
  2. "test_can_request_data" in "test_api_key.py" seems incomplete? Or I'm misunderstanding. But notably, by setting the "api_key" value as a string, it breaks the tests that come after it
  3. "test_get_acs.py" is all failing because when it inserts the geography, it sets it to its enum value (e.g. "Geography.STATE" rather than that enum's string value (e.g. "state"). I'm not sure why, but I think it's happening on line 90 of get_acs.py:
    for_geography = f"&for={geography}:*"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants