Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix status badge #1899

Merged
merged 1 commit into from
Mar 4, 2025
Merged

docs: Fix status badge #1899

merged 1 commit into from
Mar 4, 2025

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Mar 4, 2025

Description

Somehow got updated by GitHub.

Note: https://github.com/flame-engine/flame has the same problem.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@Gustl22 Gustl22 marked this pull request as ready for review March 4, 2025 07:00
@Gustl22 Gustl22 requested a review from spydon March 4, 2025 07:06
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wtf, they just made a breaking change like that without a redirect...

@Gustl22
Copy link
Collaborator Author

Gustl22 commented Mar 4, 2025

They did, but they probably forgot to support the query params 😅

@spydon
Copy link
Member

spydon commented Mar 4, 2025

Could you do the change for Flame too? 😇
I would have done it, but I'm currently backpacking in New Zealand so I don't currently have access to a computer.

@Gustl22 Gustl22 enabled auto-merge (squash) March 4, 2025 07:21
@Gustl22 Gustl22 merged commit a0c6c4f into main Mar 4, 2025
40 checks passed
@Gustl22 Gustl22 deleted the gustl22/status-badge branch March 4, 2025 07:21
@Gustl22
Copy link
Collaborator Author

Gustl22 commented Mar 4, 2025

Wow, exciting (and a little bit jealous)! Enjoy your trip!

flame-engine/flame#3517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants