Dynamic host #19
Open
Dynamic host #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow access from other ip terminals
Configure Flask dev server to be visible across the network
…uenote10-master
imadjamil
commented
Jul 6, 2022
src_frontend/store_backend.ts
Outdated
| @@ -13,7 +13,8 @@ function transformValue(x: any): any { | |||
| } | |||
|
|
|||
| export class StoreBackend implements StoreInterface { | |||
| url = "http://localhost:5000"; | |||
| // TODO: this needs to be dynamic | |||
| url = "http://127.0.0.1:5000" | |||
There was a problem hiding this comment.
This needs to be dynamic in some way. Could we guess the address of the local device on startup? or we're obliged to get it from some sort of config?
|
Hi @imadjamil and thanks for your interest in tabloo! I think the backend side can be solved simply by binding to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found tabloo useful but wanted to acceess it from another device in my local network. I succeeded to do that by hardcoding the IP address of the PC where tabloo show is running in two different files !
Then I wondered how much effort it needs to make the host configuration dynamic.
This PR puts the first brick by making server host a parameter in the backend python src which is not enough for sure.
Some work is also needed in the store_backend to make the redirection url dynamic and since I am not an expert there I prefered to publish this change and hope someone speeds the process with some help.