Add testcase for conditional packages with bnd-process #6363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a testacse where conditional package is used with bnd-process Signed-off-by: Christoph Läubrich <[email protected]>
laeubi
force-pushed
the
process_with_conditional_package
branch
from
b0d47cd to
3962626
Compare
|
I am not sure I understand the purpose? There is no test case with this as far as I can see? |
Yes there is no test-case yet for this particular use-case and that's why I added one to be sure
|
|
But there is no test that verifies the result is the same? So what will work in the future if something is changed? It is totally undefined? |
|
This is an invoker test see the others of the same kind here: https://github.com/bndtools/bnd/tree/master/maven-plugins/bnd-maven-plugin/src/it if you run the build you should see the new test somewhere between the lines mentioned when the maven plugins are build. |
|
Ok, I see the groovy now. LGTM then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a testacse where conditional package is used with bnd-process