Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In API lookups, use the exported object ID #8

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Conversation

bobg
Copy link
Owner

@bobg bobg commented Feb 25, 2024

In API lookups, use the exported object ID, not whatever ID the user has assigned (a use of) it to.

Copy link

Modver result

This report was generated by Modver,
a Go package and command that helps you obey semantic versioning rules in your Go module.

This PR does not require a change in your module’s version number.
(You might still consider bumping the patchlevel anyway.)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8039366484

Details

  • 0 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 61.758%

Files with Coverage Reduction New Missed Lines %
expr.go 2 61.57%
Totals Coverage Status
Change from base Build 8039292902: -0.04%
Covered Lines: 822
Relevant Lines: 1331

💛 - Coveralls

@bobg bobg merged commit e25314c into main Feb 25, 2024
1 check passed
@bobg bobg deleted the bobg/exported-id branch February 25, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants