This repository has been archived by the owner on Sep 3, 2019. It is now read-only.
#1033 Mark Withdrawn Cards #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryzbw
suggested changes
Oct 11, 2018
src/components/EventCard/index.js
Outdated
| @@ -92,6 +105,8 @@ export default class EventCard extends Component { | |||
| <div className={cx(classes.eventCardSection, 'top')}> | |||
| {isPending && <EventWarning id="str.pendingConfirmation" message="Pending Confirmation" />} | |||
| {isUpcoming && <EventWarning id="str.upcoming" message="Upcoming" type={EventWarningType.ORANGE} />} | |||
| {this.withdrawnStatus === 1 && <EventWarning id="str.withdrawing" message="Withdrawning" type={EventWarningType.INFO} />} | |||
There was a problem hiding this comment.
this is not working when withdraw escrow
and i also think this withdrawing is the same as pending, but pending works fine for withdraw escrow.
src/components/EventCard/index.js
Outdated
| const pendingTxs = filter(allTxs, { status: TransactionStatus.PENDING }); | ||
| const successTxs = filter(allTxs, { status: TransactionStatus.SUCCESS }); | ||
|
|
||
| if (allTxs.length === 0) return 0; |
ippudo
force-pushed
the
withdrawnMessage
branch
from
4a0d41c to
409ce84
Compare
henryzbw
approved these changes
Oct 15, 2018
ippudo
force-pushed
the
withdrawnMessage
branch
from
409ce84 to
7689a1a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1033 and it's part of followup from #496