Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added functions getSensorRawValues() #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added functions getSensorRawValues() #6

wants to merge 1 commit into from

Conversation

gplante
Copy link

@gplante gplante commented Apr 18, 2023 •
edited
Loading

Thank you for you great library.
I needed to access accel/gyro raw values so I added function getSensorRawValues() is Bmi088Accel, Bmi088Gyro and Bmi088 classes.
Thought this might be useful to other developers.

TheRedstoneHive
TheRedstoneHive approved these changes Jun 30, 2023
View reviewed changes
Copy link

@TheRedstoneHive TheRedstoneHive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making the raw accel and gyro arrays public is helpful in the event someone wants to get one of the values, and they can still use the function(s) (both for raw and transformed) to get them all at once. Overall giving the user more options is good.

@gplante
Copy link
Author

gplante commented Jul 1, 2023

Thanks, this is great.

@gplante gplante closed this Jul 1, 2023
@gplante gplante reopened this Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRedstoneHive TheRedstoneHive Awaiting requested review from TheRedstoneHive

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gplante @TheRedstoneHive