Add text to avoid empty input for input workaround #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the `input` workaround, we add a space key event to input some text before pressing the enter key. This avoid the error that happens due to gtk preventing empty input. Signed-off-by: Tin Lai <[email protected]>
|
closes #735 |
saidsay-so
requested changes
Apr 9, 2024
Comment on lines
+412
to
+415
| // try it one more time with an non-empty input field | ||
| enter_device.send_space_press(); | ||
| enter_device.send_enter_press(); | ||
|
|
There was a problem hiding this comment.
This part should be either in the first send try or in the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the
inputworkaround, we add a space key event to input some text before pressing the enter key. This avoid the error that happens due to gtk preventing empty input.This make it so that the workaround works in gtk auth like:
Pretty much after the original workaround doesn't work, we will enter a space key before pressing enter