-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/room info start: 방 시작 로직 #212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
알고 보니 client.request.user로 받아온 유저 엔티티가 너무 오래되어서 수정.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Checklist
Description
socket room-info 이벤트 및 room start로직 작업한 내용입니다
일단 시작 잘 되고 time over도 잘 되는데, time over후 제출 되어도 스코어보드에 반영하지 않도록 하는 로직이 추가적으로 필요해 보입니다.
Changes Made
client
client/src/components/Room/ProblemLists.tsx
client/src/components/Room/Problems.tsx
client/src/components/Room/RoomSettingModal/RoomSettingModal.tsx
client/src/components/Room/Timer.tsx
client/src/components/buttons/StartButton.tsx
client/src/contexts/RoomProvider.tsx
server
server/src/problem/problem.service.ts
server/src/socket/socket.gateway.ts
server/src/socket/socket.service.ts
두 함수를 구현하고 유저가 참가 / 퇴장할 때마다 room-info 이벤트를 emit합니다.
Extra Comments
Demo
2023-12-12.12.54.52.mov