fix: user id기반으로 조회하도록 변경 (#171)

boostcampwm2023 · Nov 22, 2023 · 757396e · 757396e
1 parent 0f44a6c
commit 757396e
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/BE/src/categories/categories.controller.ts b/BE/src/categories/categories.controller.ts
@@ -40,9 +40,7 @@ export class CategoriesController {
     description: '잘못된 요청입니다.',
   })
   getCategories(@User('id') user_id: number): Promise<CategoryDto[]> {
-    // TODO: 유저 id를 받아올 방식 정하기
-    user_id;
-    return this.categoriesService.findByUserId(1);
+    return this.categoriesService.findByUserId(user_id);
   }
 
   @Post()

diff --git a/BE/src/categories/categories.service.ts b/BE/src/categories/categories.service.ts
@@ -27,10 +27,6 @@ export class CategoriesService {
     return this.entityToDto(savedCategory);
   }
 
-  async findAll(): Promise<Categories[]> {
-    return this.categoriesRepository.find();
-  }
-
   async findByUserId(user_id: number): Promise<CategoryDto[]> {
     const categories = await this.categoriesRepository.find({
       where: { user_id: { id: user_id } },
@@ -47,6 +43,7 @@ export class CategoriesService {
     categoriesData: CategoryUpdateDto,
     id: number,
   ): Promise<CategoryDto> {
+    // todo - user_id를 검증
     const category = await this.categoriesRepository.findOne({
       where: { id },
       relations: ['user_id'],
@@ -58,6 +55,7 @@ export class CategoriesService {
   }
 
   async remove(user_id: number, id: number): Promise<void> {
+    // todo - user_id를 검증
     const result = await this.categoriesRepository.delete(id);
     if (result.affected === 0) {
       throw new NotFoundException('해당 카테고리가 존재하지 않습니다.');
@@ -66,7 +64,7 @@ export class CategoriesService {
 
   entityToDto(category: Categories): CategoryDto {
     const categoryDto: CategoryDto = {
-      id: category.id,
+      category_id: category.id,
       name: category.name,
       color_code: category.color_code,
     };

diff --git a/BE/src/categories/dto/response/category.dto.ts b/BE/src/categories/dto/response/category.dto.ts
@@ -6,7 +6,7 @@ export class CategoryDto {
     example: '1',
     description: '카테고리 id',
   })
-  id: number;
+  category_id: number;
 
   @ApiProperty({
     type: 'string',

diff --git a/BE/src/study-logs/study-logs.entity.ts b/BE/src/study-logs/study-logs.entity.ts
@@ -31,6 +31,7 @@ export class StudyLogs {
 
   @ManyToOne(() => Categories, (categories) => categories.study_logs, {
     eager: true,
+    nullable: true,
   })
   @JoinColumn({ name: 'category_id' })
   category_id: Categories;