Add geometry polyhedral surface #1402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include/boost/geometry/geometries/concepts/polyhedral_surface_concept.hpp
Outdated
Show resolved
Hide resolved
|
Thanks @barendgehrels for the quick review! I've addressed all your comments and replied to questions. |
tinko92
reviewed
May 2, 2025
vissarion
force-pushed
the
feature/polyhedral_surface
branch
from
afa0a38 to
adcede5
Compare
tinko92
approved these changes
May 5, 2025
barendgehrels
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #789 and adds a 3D geometry type for polyhedral surfaces according to OGC standard.
The main class, concepts, i/o and basic traits are added.
Comparing to #789 it refines the code (since that was an old PR and the library evolved since then) and also defines the polyhedral surface as a set of polygons (instead of rings) as described in the standard.
Finally, there are docs and unit tests.