Skip to content

add minimum visibility support #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

add minimum visibility support #16

wants to merge 1 commit into from

Conversation

jhunold
Copy link

@jhunold jhunold commented Sep 13, 2018

Just to get the tests going again

@apolukhin
Copy link
Member

This is related to the changes in boostorg/boost#190
Note that you also have to update all the exceptions in boost/graph/exception.hpp https://github.com/boostorg/graph/blob/4c752ee2f11c249e0d5b1fab8f0ef9da3428f575/include/boost/graph/exception.hpp#L18 by adding BOOST_SYMBOL_VISIBLE

See https://www.boost.org/doc/libs/1_65_1/libs/config/doc/html/boost_config/boost_macro_reference.html#boost_config.boost_macro_reference.macros_for_libraries_with_separate_source_code for more info

@jhunold
Copy link
Author

jhunold commented Sep 13, 2018

Well, this is just to make the unit test compile again (first shot). And yes, I know the relevant macros because I added them a long time ago.

@apolukhin apolukhin mentioned this pull request Sep 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhunold @apolukhin