Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake CI Cleanup #798

Closed
wants to merge 1 commit into from
Closed

Conversation

cmazakas
Copy link
Member

@cmazakas cmazakas commented Dec 5, 2023

URL's find_package() CMake test doesn't actually invoke any methods defined in the found DLL for Windows platforms with BUILD_SHARED_LIBS.

This PR updates the test to use components of URL with out-of-line definitions which now triggers an expected CI failure.

The fix is somewhat straight-forward, just updating he $GITHUB_PATH in any step before the Find Package one in the ci.yml.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #798 (60d94e4) into develop (d99b89a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #798   +/-   ##
========================================
  Coverage    97.27%   97.27%           
========================================
  Files          156      156           
  Lines         8565     8565           
========================================
  Hits          8332     8332           
  Misses         233      233           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d99b89a...60d94e4. Read the comment docs.

@alandefreitas
Copy link
Member

Thanks. Merged into #799, which also covers all other forms of integrating the library. There might be some changes you find useful 84b82b8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants