Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(url_base): copy operation uses reference to underlying implementation #873

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

alandefreitas
Copy link
Member

The copy operation from a url_view_base should use the pointed implementation rather than the underlying implementation so that url_views that refer to other urls are accounted for.

fix #872

…mentation

The copy operation from a url_view_base should use the pointed implementation rather than the underlying implementation so that url_views that refer to other urls are accounted for.

fix boostorg#872
@cppalliance-bot
Copy link

Antora version: an automated preview of the documentation is available at https://873.urlantora.prtest2.cppalliance.org/site/index.html

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.20%. Comparing base (2e58683) to head (dddea38).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #873      +/-   ##
===========================================
+ Coverage    99.19%   99.20%   +0.01%     
===========================================
  Files          157      157              
  Lines         8415     8415              
===========================================
+ Hits          8347     8348       +1     
+ Misses          68       67       -1     
Files with missing lines Coverage Δ
include/boost/url/url_base.hpp 100.00% <ø> (ø)
src/url_base.cpp 99.63% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e58683...dddea38. Read the comment docs.

@cppalliance-bot
Copy link

@alandefreitas alandefreitas merged commit d8cacb5 into boostorg:develop Oct 25, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resolve fails when using assigned-to url_view
2 participants