BST-13481: add new baseline scanner #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fproulx-boostsecurity
force-pushed
the
main
branch
from
6fecac1 to
7a87d81
Compare
JonathanSerafini
force-pushed
the
BST-13481/metascanner
branch
from
8b2e427 to
803b31e
Compare
lindycoder
reviewed
Nov 18, 2024
lindycoder
reviewed
Nov 18, 2024
lindycoder
previously approved these changes
Nov 21, 2024
|
@lindycoder rather than state that something is or is not right, could you provide the value you want ? |
lindycoder
reviewed
Nov 22, 2024
| @@ -1,24 +1,23 @@ | |||
| api_version: 1.0 | |||
|
|
|||
|
|
|||
| group: boostsecurityio/groups/scanner | |||
There was a problem hiding this comment.
Sorry my bad, this should be boostsecurityio/scanner
There was a problem hiding this comment.
cool thnx, i'll update asap
|
@JonathanSerafini sorry i never completed by review |
lindycoder
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves the
boostsecurity/scannertoboostsecurity/baselinecreates a new
boostsecuriy/scannerwith includes on other scannersthis new scanner will now emit grouping results to the api.
please let me know if youd prefer the name and/or includes be different