-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various Improvements #1943
base: develop
Are you sure you want to change the base?
Various Improvements #1943
Conversation
@dellaert reminder |
@@ -41,6 +41,7 @@ | |||
#include <string> | |||
|
|||
#define GTSAM_PRINT(x)((x).print(#x)) | |||
#define GTSAM_COUT(x) (std::cout << #x ": " << x << std::endl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But print already assumes cout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more for types that don't support .print()
. I can use this to print doubles, strings etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then just use std::cout, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be convenient to do GTSAM_COUT(x)
instead of std::cout << "x: " << x << std::endl;
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a GTSAM thing
maybe-uninitialized
warnings from Eigen for Release build. We only see this warning in Eigen, and since this is a vendored version, the assumption is that the original developers have already accounted for this to not be a problem.resetIntegration
to initialize theImuFactor
andCombinedImuFactor
classes.ImuFactor2
.GTSAM_COUT
which is for classes/types that don't have a.print()
defined or have the<<
operator overloaded. An example usage is below:Rot3 wRb = Rot3(); GTSAM_COUT(wRb);
which prints
Interestingly, there is no
CombinedImuFactor2
which works onNavState
s. This should be a TODO for us given the recent importance of NavState.