feat: persistent max age #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #289
💥 BREAKING CHANGE 💥
The
maxAgeoption now ensures that the cache becomes invalid after the specified cache lifetime is reached based onstats.mtimeMs(last modification time of the cache file) instead of relying on an in memory timeout that invalidates the cache. This ensures that cache lifetimes are evaluated correctly between multiple processes.How to upgrade
If you are using the
maxAgeoption, ensure that you add the option to everymemoizer.fncall (if you have multiple) to reliably check cache validity. Most probably this is already the case in your application, and you don't need to change anything.