Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KakaoTalk #361

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add KakaoTalk #361

wants to merge 1 commit into from

Conversation

trafotin
Copy link

@trafotin trafotin commented Dec 5, 2024

Add support for the instant messenger KakaoTalk.

Type of change

  • New installer
  • Manifest fix
  • Other

Was This Tested Using a Local Repository?

  • Yes
  • No

Running the installer is pretty easy, but you need to change the fonts in a menu to a CJK compatible font. For some reason on my machine, Bottles pulls from my ~/.local/share/fonts folder. I deleted all my fonts and chose the font Source Sans Han, but this may need to be changed if it doesn't work on a fresh install.

There also needs to be a PNG of KakaoTalk. It can be found here: https://t1.kakaocdn.net/kakaocorp/kakaocorp/admin/5f9c58c2017800001.png

@mirkobrombin mirkobrombin self-requested a review December 21, 2024 18:34
@mirkobrombin
Copy link
Member

Thanks, I'll test this asap!

Copy link
Contributor

@jntesteves jntesteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Needs review file
  • Needs icon file
  • Need to add to index.yml
  • Needs testing

I'm changing to Draft until this is ready for review. Thanks for working on this.

@jntesteves jntesteves marked this pull request as draft December 29, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants