workflow 1.1 adaptations

[slaxor]

Hi,

the method containers in Workflow have changed, Here is the fix
Best regards
Sascha

[bowsersenior]

Thanks for the pull request. Looks OK, but the tests seem to fail on Travis CI. I will look into fixing those and merge this in soon.

[slaxor]

Yeah I have seen the failure, but since it (seemingliy) had nothing to do with my change I assumed it must've been something unrelated. should I also look into it?

[bowsersenior]

Hi @slaxor . The failing test on Travis is due to a versioning issue with the Mongoid gem. However, there are some other things that need to be done for proper compatibility with workflow 1.1 :

• Change folder structure and namespaces to match new workflow pattern (lib/workflow/adapters/mongoid.rb and Workflow::Adapter::Mongoid::InstanceMethods)
• Copy over new tests from workflow to ensure everything works

If you could have a look at the issues above, that would be great. Otherwise, I will try to get to these in the next week or so.

[bowsersenior]

Sorry I haven't gotten around to this. The bad news is that the new version of workflow requires a major change to this workflow_on_mongoig gem. The good news is that it should simplify things quite a bit since all that is needed is a single adapter for mongoid . See the ActiveRecord adapter for the basic structure:

• https://github.com/geekq/workflow/blob/master/lib/workflow/adapters/active_record.rb

Will try to get to this in the next week!

[bowsersenior]

Hi @slaxor . I got Mongoid to work with the original workflow gem's latest version and opened a pull request there:

• Add mongoid support geekq/workflow#99

We'll see if that gets accepted, then you'll be able to use workflow with Mongoid.

[bowsersenior]

@slaxor Looks like my pull request isn't going to be included. I realize I don't have enough time to continue supporting this gem. My best advice to you is to switch to a different state machine like https://github.com/pluginaweek/state_machine which includes Mongoid support.

[slaxor]

thanks for your advice, i might do this but its not really urgent right now
since everything i do seems to be working

On Thu, Feb 27, 2014 at 5:57 PM, Mani Tadayon [email protected]:

@slaxor https://github.com/slaxor Looks like my pull request isn't
going to be included. I realize I don't have enough time to continue
supporting this gem. My best advice to you is to switch to a different
state machine like https://github.com/pluginaweek/state_machine which
includes Mongoid support.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/12#issuecomment-36263898
.

N 53° 33.283 E 010° 02.623
http://tinyurl.com/2nplah