add support for custom offline atlases #497
Open
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it now reads atlases from cached last_versions.conf and custom.conf files
carlocastoldi
force-pushed
the
offline-custom-atlases
branch
from
a293bb0 to
aafca92
Compare
|
i don't think i introduced a bug that makes the test not pass, am i? It's on atlasgen |
IgorTatarnikov
approved these changes
Feb 13, 2025
| @@ -59,18 +59,22 @@ def get_local_atlas_version(atlas_name): | |||
| def get_all_atlases_lastversions(): | |||
| """Read from URL or local cache all available last versions""" | |||
| cache_path = config.get_brainglobe_dir() / "last_versions.conf" | |||
| custom_path = config.get_brainglobe_dir() / "custom.conf" | |||
There was a problem hiding this comment.
Suggested change
| custom_path = config.get_brainglobe_dir() / "custom.conf" | |
| custom_path = config.get_brainglobe_dir() / "custom_atlas.conf" |
There was a problem hiding this comment.
wouldn't custom_atlases.conf be a better name, then?
There was a problem hiding this comment.
custom_atlases.conf also works!
Co-authored-by: Igor Tatarnikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this small PR, i want to enable atlas developers to test their atlases using BrainGlobe's pipeline.
As of now, if the atlas is not official (i.e. present on the Gin repository), it updates the
last_versions.conffile overriding any local changes that may have added a new custom local atlas.This PR intends to read the atlases from both the cached file of
last_versions.confandcustom.conffile.custom.conffollows the same structure aslast_versions.conf.Description
What is this PR
References
discussed over on Zulip.
How has this PR been tested?
python -c "import brainglobe_atlasapi as bg; print(bg.list_atlases.get_all_atlases_lastversions())"with
custom.conffile both existing and not.Is this a breaking change?
no
Does this PR require an update to the documentation?
Perhaps?
Checklist: