-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force cpu usage on macos-latest runners #114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 85.64% 85.83% +0.18%
==========================================
Files 16 17 +1
Lines 836 847 +11
==========================================
+ Hits 716 727 +11
Misses 120 120 ☔ View full report in Codecov by Sentry. |
@IgorTatarnikov is this ready for review? |
Yes! Forgot to mark is as ready. |
adamltyson
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
Currently, the macos-latest does not have access to a GPU, however,
torch.backends.mps.is_available()
returns true leading to issues when keras tries to allocate a tensor on the GPU. This leads to errors during testing.What does this PR do?
Forces
keras
andtorch
to use CPU when running on the macos-latest runner (identified byGITHUB_ACTIONS
env variable andtorch.backends.mps.is_available()
.How has this PR been tested?
Tested locally and on CI.
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: