Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve atlas details within atlas API docs #249

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Improve atlas details within atlas API docs #249

merged 4 commits into from
Sep 12, 2024

Conversation

adamltyson
Copy link
Member

Closes #247

@adamltyson adamltyson requested a review from a team September 11, 2024 12:51
IgorTatarnikov
IgorTatarnikov approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good! Do we merge this with the change to build_shphinx_docs action or wait for the resolution of that discussion?

@adamltyson
Copy link
Member Author

I think the fix on our side is simple, and I just pushed. This should be safe even with a new release of the build workflow.

@IgorTatarnikov
Copy link
Member

Should 1877475 (#249) be reverted before merging?

@adamltyson
Copy link
Member Author

I don't think so. I think it's better to make sure we're using the latest release (well 2.x), rather than whatever is on main.

@IgorTatarnikov IgorTatarnikov merged commit ee15990 into main Sep 12, 2024
3 checks passed
@IgorTatarnikov IgorTatarnikov deleted the atlas-details branch September 12, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorTatarnikov IgorTatarnikov IgorTatarnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more details for new atlases
2 participants
@adamltyson @IgorTatarnikov