This repository has been archived by the owner on Aug 8, 2019. It is now read-only.
add CFNetwork replacement for iOS9 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The source listed above doesn't match the one in the documentation in the file. That section just links to Wikipedia. You should update that comment or at least add the source to the commit message. |
| @@ -807,10 +807,14 @@ os_parsers: | |||
| - regex: 'CFNetwork/6.* Darwin/(14)\.\d+' | |||
| os_replacement: 'iOS' | |||
| os_v1_replacement: '7' | |||
| - regex: 'CFNetwork/7.* Darwin/(14)\.\d+' | |||
| - regex: 'CFNetwork/711.* Darwin/(14)\.\d+' | |||
There was a problem hiding this comment.
is 711 the only version that is iOS 8?
There was a problem hiding this comment.
Just looked at the source, and it appears so.
|
The source I provided is used for all the CFNetwork regexes, see line 756. |
|
Then lines 791-794 are very confusing. |
|
I think the Wikipedia source is for the Darwin versions, whereas the link in 756 is for CFNetwork versions. A bit confusing, but also feels redundant to repeat the source in the comments. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the replacement for the version of CFNetwork on iOS9. Source of the version number is from the same source of the other version numbers.