-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX tailwindcss standalone build on monorepos #694
Conversation
… prevents having broken symlinks
brisa-adapter-vercel
brisa-pandacss
brisa
brisa-tailwindcss
create-brisa
www
commit: |
Co-authored-by: Aral Roca Gomez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if instead of:
- Copy
- Detect and if it exists .bin delete it
Could we directly just copy if from
does not contain node_modules/.bin
?
It would also be nice to add the tests for this change.
How the logic is now no. Reason is because we are copying the whole path recursively, so we don't have information about the inner folder. And we need to copy the dependency. |
I will have no issues doing how you say, but I don't see too much benefit. I'll add a test, do not merge yet. |
Less work... Copy + detect + delete are 3 operations, detect and avoid copy would be 1. |
This fixes the standalone build for tailwindcss when used on a monorepo, prevents having broken symlinks from the folder ".bin".