Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate and simplify passthroughs #1484

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -71,20 +71,18 @@ trait FireCloudApiService
with RegisterApiService
with WorkspaceApiService
with WorkspaceV2ApiService
with NotificationsApiService
with MethodConfigurationApiService
with BillingApiService
with SubmissionApiService
with StatusApiService
with MethodsApiService
with Ga4ghApiService
with UserApiService
with ShareLogApiService
with ManagedGroupApiService
with CromIamApiService
with HealthApiService
with StaticNotebooksApiService
with PerimeterApiService {
with PerimeterApiService
with PassthroughApiService {

override lazy val log = LoggerFactory.getLogger(getClass)

Expand Down Expand Up @@ -184,7 +182,6 @@ trait FireCloudApiService
methodConfigurationRoutes ~
submissionServiceRoutes ~
nihRoutes ~
billingServiceRoutes ~
shareLogServiceRoutes ~
staticNotebooksRoutes ~
perimeterServiceRoutes
Expand Down Expand Up @@ -217,14 +214,14 @@ trait FireCloudApiService
managedGroupServiceRoutes ~
workspaceRoutes ~
workspaceV2Routes ~
notificationsRoutes ~
statusRoutes ~
ga4ghRoutes ~
pathPrefix("api") {
apiRoutes
} ~
// insecure cookie-authed routes
cookieAuthedRoutes
cookieAuthedRoutes ~
// wildcard passthrough routes. These must be last to allow other routes to override them.
passthroughRoutes
}

}
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package org.broadinstitute.dsde.firecloud.webservice

import akka.http.scaladsl.server.{Directives, Route}
import org.broadinstitute.dsde.firecloud.FireCloudConfig
import org.broadinstitute.dsde.firecloud.utils.StreamingPassthrough

trait PassthroughApiService extends Directives with StreamingPassthrough {

private lazy val agora = FireCloudConfig.Agora.baseUrl
private lazy val rawls = FireCloudConfig.Rawls.baseUrl

val passthroughRoutes: Route = concat(
pathPrefix("ga4gh")(streamingPassthrough(s"$agora/ga4gh")),
pathPrefix("api" / "billing")(streamingPassthrough(s"$rawls/api/billing")),
pathPrefix("api" / "notifications")(streamingPassthrough(s"$rawls/api/notifications"))
)

}

This file was deleted.

This file was deleted.

Loading
Loading