Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CHR2 and END2 for CPX at the end of CleanVcf #583

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

epiercehoffman
Copy link
Collaborator

Updates

Remove CHR2 and END2 fields (if they exist) for all CPX records at the end of CleanVcf. These fields are redundant with the information in CPX_INTERVALS and are currently inconsistent and confusing (#377).

Testing

  • Validated all WDLs and JSONs with womtool & terra validation script
  • Rebuilt sv_pipeline_docker (us.gcr.io/broad-dsde-methods/eph/sv-pipeline:eph-cpx-remove-chr2-end2-6feed34) and tested CleanVcf with reference panel data. The workflow ran successfully and the resulting VCF did not have CHR2 or END2 fields for CPX records.

Note

Downstream workflows should be tested and updated if needed to comply with this change.

Copy link
Collaborator

@mwalker174 mwalker174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, just a small GATK update will be needed for SVConcordance downstream.

@epiercehoffman epiercehoffman merged commit ed1ef87 into main Aug 10, 2023
4 checks passed
@epiercehoffman epiercehoffman deleted the eph_cpx_remove_chr2_end2 branch August 10, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants