Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Google Cloud configuration JSONs #711

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

kjaisingh
Copy link
Collaborator

This PR addresses Issue #709.

Description

Deprecates all google_cloud.*.json files, as well as the CLOUD_ENV variable, as these are no longer used in building inputs for workflows. Also removes any code or documentation references to these.

Testing

Successfully ran the two commands listed below. The first command does not utilize the -c parameter, which was traditionally used to pass in the Google Cloud configuration details.

bash scripts/inputs/build_default_inputs.sh -d .
bash scripts/test/validate.sh -d . -j womtool-87.jar -t

@kjaisingh kjaisingh self-assigned this Aug 15, 2024
@kjaisingh kjaisingh added the enhancement New feature or request label Aug 26, 2024
@kjaisingh kjaisingh changed the title Deprecates Google Cloud configuration JSONs Deprecate Google Cloud configuration JSONs Aug 27, 2024
Copy link
Member

@VJalili VJalili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for simplifying the input generation! Could you please update the related parts on the documentation to reflect these changes (e.g., this page)?

@kjaisingh
Copy link
Collaborator Author

kjaisingh commented Sep 10, 2024

@VJalili I believe that the PR already includes changes to relevant documentation files (which are listed below), but please let me know if I am missing anything else here - e.g. if I should be more explicit about the fact that the -c option is now deprecated.

  • README.md
  • website/docs/advanced/build_inputs.md
  • website/docs/gs/quick_start.md

@VJalili
Copy link
Member

VJalili commented Sep 10, 2024

You're right; thanks for pointing out the changes.

Copy link
Collaborator

@epiercehoffman epiercehoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! I'm excited to not have to deal with this JSON anymore. I tested this locally with success.

kjaisingh

This comment was marked as resolved.

@VJalili
Copy link
Member

VJalili commented Sep 19, 2024

@kjaisingh, this is a long-wanted deprecation! Thank you!! 🎉 🎉

@kjaisingh kjaisingh merged commit a436703 into main Sep 19, 2024
8 checks passed
@kjaisingh kjaisingh deleted the kj/709_deprecate_cloud_env_json branch September 19, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate cloud_env JSON / google_cloud.my_project.json for building inputs
3 participants