-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Google Cloud configuration JSONs #711
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for simplifying the input generation! Could you please update the related parts on the documentation to reflect these changes (e.g., this page)?
@VJalili I believe that the PR already includes changes to relevant documentation files (which are listed below), but please let me know if I am missing anything else here - e.g. if I should be more explicit about the fact that the
|
You're right; thanks for pointing out the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up! I'm excited to not have to deal with this JSON anymore. I tested this locally with success.
@kjaisingh, this is a long-wanted deprecation! Thank you!! 🎉 🎉 |
This PR addresses Issue #709.
Description
Deprecates all
google_cloud.*.json
files, as well as theCLOUD_ENV
variable, as these are no longer used in building inputs for workflows. Also removes any code or documentation references to these.Testing
Successfully ran the two commands listed below. The first command does not utilize the
-c
parameter, which was traditionally used to pass in the Google Cloud configuration details.