-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter outlier samples in TrainGCNV and GenerateBatchMetrics #717
Open
kjaisingh
wants to merge
44
commits into
main
Choose a base branch
from
kj/44_outlier_sample_removal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjaisingh
changed the title
Outlier Sample Removal in Train gCNV, GenerateBatchMetrics and FilterBatchSites
Outlier Sample Removal in TrainGCNV, GenerateBatchMetrics and FilterBatchSites
Aug 27, 2024
kjaisingh
changed the title
Outlier Sample Removal in TrainGCNV, GenerateBatchMetrics and FilterBatchSites
Filter Outlier Samples in TrainGCNV, GenerateBatchMetrics and FilterBatchSites
Aug 27, 2024
kjaisingh
changed the title
Filter Outlier Samples in TrainGCNV, GenerateBatchMetrics and FilterBatchSites
Filter outlier samples in TrainGCNV, GenerateBatchMetrics and FilterBatchSites
Aug 27, 2024
kjaisingh
changed the title
Filter outlier samples in TrainGCNV, GenerateBatchMetrics and FilterBatchSites
Filter outlier samples in TrainGCNV and GenerateBatchMetrics
Aug 27, 2024
kjaisingh
force-pushed
the
kj/44_outlier_sample_removal
branch
from
August 30, 2024 14:57
0c4fae2
to
7da11ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #44.
Description
TrainGCNV
Array[String]? sample_ids_training_subset
withFile? outlier_sample_ids
, as the former was not being actively used before. The new parameter represents a text file containing outlier samples.Utils.GetFilteredSubsampledIndices
that usesoutlier_sample_ids
and/oroutlier_sample_ids
to subsample based on the following logic:exclude_strings
is provided, then only include samples that are not part of theoutlier_sample_ids
file.subset_size
is provided, then only include onlyn_samples_subsample
random samples.exclude_strings
andsubset_size
are provided, thenn_samples_subsample
random samples that are not part of theoutlier_sample_ids
file.exclude_strings
norsubset_size
are provided, include all samples.Utils.GetFilteredSubsampledIndices
.GenerateBatchMetrics
File? outlier_sample_ids
to represent a text file containing outlier samples.--outlier-sample-ids
, which provides a path to a file containing outlier samples. The metric calculation process in these tests are modified as follows:is_outlier_specific
in the output VCF withTrue
if it corresponds to a site that only has outlier samples tagged to it, and withFalse
if not.FilterBatchSites
No changes included - we already filter out sites from the training process using the
is_outlier_specific = True
tag that we now populate in GenerateBatchMetrics.Testing
count_entity_ids
parameter forCNVGermlineCohortWorkflow
that only 150 samples are passed into the model training step - none of which are listed in the outlier sample file..metrics
and.stats
files produced across tests due to the presence of outliers, the called variants have varying levels of support.Pre-Merge Changes Required
.dockstore.yml
.exclude_sample_ids.txt
file from the EvidenceQC notebook - samples part of this should not be dropped from the metrics table though.