reproducing with updated dependencies #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alxndrkalinin
commented
Jan 19, 2023
alxndrkalinin
commented
- updated environments compatible with Apple silicon (cannot install using environment.yml #34)
- refactored code to be compatible with updated dependencies
- reproduced all analysis, except for single cell Cell Health data
- added black formatting, with github actions and pre-commit
to comply with changes introduced in 0d0c42e1ed6129c2c2d96614cfaa6628f99a0d49
|
Happy new year @gwaybio! I wanted to confirm that you're not going to review PRs for this repo, only for cytominer-eval, and I can merge without review. |
|
I view this repo as entirely handed over to you for your preferred maintenance plan. I don't have time for full scale reviews, but I'd be happy to offer my eyes for targeted requests. Thanks for clarifying! |
|
Sounds good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.