Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID-361 Add breadcrumbs and release hash for sentry. #143

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Ghost-in-a-Jar
Copy link
Contributor

Jira: https://broadworkbench.atlassian.net/browse/ID-361

Duplicates the setup in sam to add logback support, release hash, breadcrumbs. Basically more sentry features.


  • Submitter: Make sure Swagger is updated if API changes
  • Submitter: If updating admin endpoints, also update firecloud-admin-cli
  • Submitter: Update FISMA documentation if changes to:
    • Authentication
    • Authorization
    • Encryption
    • Audit trails
  • Submitter: If you're adding new libraries, sign us up to security updates for them

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.24 ⚠️

Comparison is base (fee9fac) 61.18% compared to head (74bbf93) 60.95%.

❗ Current head 74bbf93 differs from pull request most recent head b196897. Consider uploading reports for the commit b196897 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #143      +/-   ##
===========================================
- Coverage    61.18%   60.95%   -0.24%     
===========================================
  Files           13       13              
  Lines          523      525       +2     
  Branches        54       52       -2     
===========================================
  Hits           320      320              
- Misses         203      205       +2     
Impacted Files Coverage Δ
src/main/scala/thurloe/Main.scala 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ghost-in-a-Jar Ghost-in-a-Jar force-pushed the ID-361-add-breadcrumbs-release-hash branch from 74bbf93 to b196897 Compare March 8, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants