Fix: Skip Non-HTTP Protocol in New Tab Handling to Prevent Errors #529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Opening a new tab with certain protocols (
blob:
,tel:
,about:
,javascript:
, etc.) was causing navigation errors whengoto
was attempted on an invalid URL. This resulted inProtocol error (Page.navigate): Cannot navigate to invalid URL
, affecting test execution and stability.#527
It addresses the following issue where
newOpenedTab
is identified as:
when the url to navigate to is in a new tab and the protocol does not start withhttp
.E.g.
const url = "blob:http://localhost:3001/3bdb0769-7903-4173-b655-89275ac7296f";
const url = "tel:+447555333222";
const url = "mailto:[email protected]";
What Changed
"http"
before attempting to navigate usinggoto
.Test Plan
about:blank
,blob:
,mailto:
) to ensure they are ignored without causing errors.