Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Support wildcard for Basic auth domains #266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

doublemarket
Copy link

By merging this PR, the domain name for a basic auth setting allows wildcards (*). e.g. *.example.com matches foobar.example.com, * matches any hostname.

Note that I confirmed that this passes tests on the latest master branch but the jar file based on it doesn't work due to the #263. I confirmed the jar file generated based on 2.0.1 + changes in this PR works.

@ericbeland
Copy link
Contributor

We have some big changes coming in about a month. We're trying an approach to drop littleproxy. I feel bad about it, but I think the basic auth part just got hit with a minor rewrite. I'd like to review when that change lands.

@doublemarket
Copy link
Author

@ericbeland Wow, that's a big news! I'm looking forward to see the changes. Please review if this PR still has some values with the new version. Otherwise... heh, no worries 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants