Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added More Verification && Updated Docs #47

Closed
wants to merge 3 commits into from
Closed

Conversation

soranoo
Copy link
Contributor

@soranoo soranoo commented Oct 20, 2023

[ + ] Added Slot ID Verification
[ + ] Documented GoogleAdSense and ResponsiveAdUnit Components
[ # ] Updated publisherId argument from GoogleAdSense and ResponsiveAdUnit to optional argument (allow shorter and clearer component)
[ # ] Updated README.md for clear instruction
[ # ] Updated package.json Version Code from 1.0.0 to 1.0.1

Please release a new version after accepting this pull request.

@soranoo
Copy link
Contributor Author

soranoo commented Oct 20, 2023

It is totally fine in my dev test but the workflow failed.
image
How's your test work?

@soranoo soranoo closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant