Bug 1853138/Bug 1886954 - Switch to Email::Sender and Email::Address::XS #103
Conversation
|
To not require Email::Address::XS independently, I've cherry-picked and rebased the patches migrating from Email::Send to Email::Sender into this branch. |
|
I'm going to need a little help getting the tests passing though.. looks like we use a separate docker build for perl dependencies that doesn't respect changes to cpanfile here.. I'll need someone to explain how your workflow works to be able to get those updated dependencies pulled in prior to the tests being able to run as expected. |
mrenvoize
force-pushed
the
bug_1853138
branch
from
36881e0 to
749cc93
Compare
|
Squashed a couple of minor fixes highlighted by failing tests on the corresponding 5.2 pull request. |
mrenvoize
force-pushed
the
bug_1853138
branch
2 times, most recently
from
d084a38 to
363b4a1
Compare
mrenvoize
force-pushed
the
bug_1853138
branch
2 times, most recently
from
2a2269a to
2366221
Compare
mrenvoize
force-pushed
the
bug_1853138
branch
from
848a2f4 to
306049d
Compare
I believe I resolved these as soon as they were reported, hopefully, tests should all be passing now once given the opportunity to run. I've rebased the branch now the CircleCI updates have landed too, thanks for working on that :) |
|
Can we run the tests here please.. |
mrenvoize
force-pushed
the
bug_1853138
branch
2 times, most recently
from
1ef3141 to
82cbc3b
Compare
This patch updates us from using Email::Address to Email::Address::XS to resolve CVE-2015-7686. Regex comparisons have been replaced by parse + is_valid calls as per current documentation.
r=dylan a=glob (cherry picked from commit 5d96fa7) Signed-off-by: Martin Renvoize <[email protected]>
…h Email::Sender::Transport::Sendmail r=dylan a=justdave (cherry picked from commit 0ff4174) Signed-off-by: Martin Renvoize <[email protected]>
… Email::Sender r=dkl a=glob (cherry picked from commit 226b92c) Signed-off-by: Martin Renvoize <[email protected]>
Git decided to drop some of the changes introduce by the commit we cherry-picked during the pick. This patch restores them and thus gets the module compiling again. Cherry-pick in question was of commit 0ff4174
This patch introduced the Email::Address::XS entry in Makefile.PL so that we can specify which version of the module we wish to use and make it explicit that we're using the module rather than relying on Email::Sender pulling it in for us.
justdave
changed the title
This patch updates us from using Email::Address to Email::Address::XS to resolve CVE-2015-7686.
Regex comparisons have been replaced by parse + is_valid calls as per current documentation.
Additional info