Push images to Public ECR #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
push-to-public-ecr
branch
4 times, most recently
from
f976131 to
45b6ac7
Compare
DrJosh9000
force-pushed
the
push-to-public-ecr
branch
from
45b6ac7 to
f6af4cc
Compare
yob
approved these changes
Dec 16, 2024
This was referenced Dec 16, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Publish dev builds (anything CI has run on but is not tagged with a version) to Public ECR only - in specific
-devrepo paths.Publish release builds to both Public ECR and GHCR.
Why
Addresses one of the key issues raised in #384 - currently it is not easy to disambiguate supported release builds from random dev builds just by looking at the GitHub Packages page. Moving the dev builds to separate dev repos accomplishes this.
Public ECR was also chosen because it is easy to set up with Terraform, and supports OIDC-assumable roles for pushing.
At some point we should also push releases to Buildkite Packages 😄