Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EDGE-1520] Add pipeline templates rest & graphql api documentation #2479
[EDGE-1520] Add pipeline templates rest & graphql api documentation #2479
Changes from 10 commits
aeeacc0
d31f8fc
afb1445
c5c1818
576be62
9070800
861d405
a028f8d
7e0d3ed
f376798
846c62a
8f472e4
729d77f
6e8fe10
f06384c
9b5dc00
9c7ce98
810210b
45987ac
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "manage pipeline" the name of the permission in the UI? If so, I think it would be good to use italics:
Or, consider the following alternate, which I think reads a little better:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Manage pipeline" isn't the permission we use in the UI, I used it to collectively describe
read_project
andcreate_project
permissions :).Do you think we should be more specific with the permissions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay. Hmmm is there anywhere else that tells them that specific info? The first place I checked was our GraphQL schema docs, but that doesn't include permission requirements. The next place I looked was the Pipeline templates page, which has:
Is that the equivalent info?
If so, I think it's fine to just use my second suggestion: "Admins and users with permission to manage pipelines can..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The closest page I can think of that has a similar granularity on permissions would be on the pipeline templates rest api page. Each of the endpoints list out what permissions and api token scopes are required in order to use the api.
Cool, I ran with your second suggestion in lieu of any other updates we may want to make in the future :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's match the order used in the navigation:
(I think I saw the start of a conversation somewhere about the ordering of these pages, but I can't find it now. There were reasons they weren't in alphabetic order, but I think it's fine to switch to that given how many pages we have now)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great pick up @mbelton-buildkite, I lost track of which pages are automatically generated vs which ones aren't 😅.
That convo I had with Chris mentioned whether or not we should alphabetically sort links under the Pipelines REST API:
Do you have opinions on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh okay. Yeah, for reference docs with that many entries, I think moving to order alphabetically is a good idea 😊
I think I have a feature request somewhere to generate index sections like that on Overview pages, so one day it hopefully won't be manual!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks your for input @mbelton-buildkite, I'll go ahead and order the list alphabetically :D
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.