Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Run Issues to the Test Analytics docs #2482

Merged
merged 11 commits into from
Sep 25, 2023
Merged

Add Run Issues to the Test Analytics docs #2482

merged 11 commits into from
Sep 25, 2023

Conversation

meghan-kradolfer
Copy link
Contributor

@meghan-kradolfer meghan-kradolfer commented Sep 18, 2023 •
edited
Loading

Adding the new Run Issues into the Test Analytic docs. Including a useful description on each issue that we find and where the user can see the issues appear.

Changes:

  • Added run issues to 'Configuring test suites'
  • Included a private beta notice which will be removed when we go GA (29/9)
  • Added run issues to the TA overview page
  • Removed icons on the overview page (request from Jasmin)

Linear ticket:
Add Run Issues to the Test Analytics docs

Screenshot 2023-09-19 at 10 12 44 AM Screenshot 2023-09-19 at 10 11 20 AM

@github-actions github-actions bot added the test-analytics Pull requests that update content related to Test Analytics label Sep 18, 2023
@buildkite-docs-bot
Copy link
Contributor

Preview URL: https://2482--bk-docs-preview.netlify.app

KatieWright26
KatieWright26 reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@KatieWright26 KatieWright26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm keen to know what the docs people think - I feel like the beta flag should be at the top of the section?
Also, the slow issue wording feels a bit awkward still; keen for feedback around that

MelissaKaulfuss
MelissaKaulfuss reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@MelissaKaulfuss MelissaKaulfuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, yes to moving the beta flag to the top of the page!

data/tiles.yml Outdated Show resolved Hide resolved
pages/test_analytics/test_suites.md Outdated Show resolved Hide resolved
pages/test_analytics/test_suites.md Outdated Show resolved Hide resolved
pages/test_analytics/test_suites.md Outdated Show resolved Hide resolved
MelissaKaulfuss
MelissaKaulfuss reviewed Sep 21, 2023
View reviewed changes
pages/test_analytics/test_suites.md Outdated Show resolved Hide resolved
pages/test_analytics/test_suites.md Outdated Show resolved Hide resolved
MelissaKaulfuss
MelissaKaulfuss approved these changes Sep 24, 2023
View reviewed changes
Copy link
Contributor

@MelissaKaulfuss MelissaKaulfuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! ✅

@meghan-kradolfer meghan-kradolfer force-pushed the add-test-analytics-issues branch from f23a561 to 5e12d9f Compare September 25, 2023 00:14
@meghan-kradolfer meghan-kradolfer merged commit 8407c1e into main Sep 25, 2023
1 check passed
@meghan-kradolfer meghan-kradolfer deleted the add-test-analytics-issues branch September 25, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KatieWright26 KatieWright26 KatieWright26 approved these changes

@MelissaKaulfuss MelissaKaulfuss MelissaKaulfuss approved these changes

@jasminwong jasminwong Awaiting requested review from jasminwong

@mbelton-buildkite mbelton-buildkite Awaiting requested review from mbelton-buildkite

@meiqimichelle meiqimichelle Awaiting requested review from meiqimichelle

Assignees
No one assigned
Labels
test-analytics Pull requests that update content related to Test Analytics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@meghan-kradolfer @buildkite-docs-bot @MelissaKaulfuss @KatieWright26