Bugfix: Fix cluster metrics routing #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-suzuki
requested review from
mbelton-buildkite,
MelissaKaulfuss and
meiqimichelle
as code owners
github-actions
bot
added
the
pipelines
|
Preview URL: https://2498--bk-docs-preview.netlify.app |
kalopilato
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
I've given this a test in PR preview (so good!) and works as expected. It's a little disorientating jumping from "Clusters / Queue metrics" to "Insights / Cluster queue metrics" in the sidebar nav but I don't see a better way while we have two links to the same page (without duplicating and maintaining two copies of the same page that is)
This is at least an improvement on prior behaviour 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug picked up by @kalopilato in #2492 (comment) (this was noticed just after the PR was merged)