Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Playwright section to Javascript Collectors page #2514

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

nprizal
Copy link
Contributor

@nprizal nprizal commented Oct 6, 2023

Description

We have added Playwright support to our JavaScript test collector. This PR adds an instruction to configure test collector with Playwright in JavaScript collectors page.

Context

https://linear.app/buildkite/issue/PIE-2029
buildkite/test-collector-javascript#72

Verification

Screenshot 2023-10-06 at 2 06 33 PM Screenshot 2023-10-06 at 2 06 40 PM

Deployment

We need to release this after we release buildkite-test-collector v1.6.0

@github-actions github-actions bot added the test-analytics Pull requests that update content related to Test Analytics label Oct 6, 2023
@nprizal nprizal self-assigned this Oct 6, 2023
@buildkite-docs-bot
Copy link
Contributor

Preview URL: https://2514--bk-docs-preview.netlify.app

@@ -57,7 +58,7 @@ To configure Jest:
}
```

### Jasmine collector
### Jasmine
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the collector to make it consistent with Jest

@nprizal nprizal requested a review from a team October 6, 2023 02:20
Copy link
Contributor

@mbelton-buildkite mbelton-buildkite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😊

@nprizal nprizal merged commit 10e670a into main Oct 11, 2023
@nprizal nprizal deleted the pie-2029/add-playwright-to-javascript-collectors branch October 11, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-analytics Pull requests that update content related to Test Analytics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants