Add ecr scan step #2519
Merged
Add ecr scan step #2519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL: https://2519--bk-docs-preview.netlify.app |
|
Nice one. Thanks @danstn |
dannymidnight
approved these changes
Oct 9, 2023
yob
reviewed
Oct 9, 2023
| - name: ":ecr: ECR Vulnerabilities Scan" | ||
| command: "true" | ||
| soft_fail: true | ||
| plugins: |
There was a problem hiding this comment.
does this need a depends_on to ensure it runs after the image is pushed?
There was a problem hiding this comment.
Yes. Updated here 6ce1032.
yob
reviewed
Oct 9, 2023
| plugins: | ||
| - buildkite/ecr-scan-results#v1.2.0: | ||
| image-name: "${ECR_REPO}:${BUILDKITE_BUILD_NUMBER}" | ||
|
|
||
| # If the current user is part of the deploy team, then wait for everything to | ||
| # finish before deploying | ||
| - wait: ~ |
There was a problem hiding this comment.
does this wait need to depend on the ECR scan? Maybe not now I guess, while the ECR scan is soft fail?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will introduce a soft-fail step that will add ECR scan results to build annotation.