-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concurrency group issues with block/input steps #2620
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a known issue when using concurrency group with block/input steps
github-actions
bot
added
the
pipelines
Pull requests that update content related to Pipelines
label
Jan 18, 2024
Preview URL: https://2620--bk-docs-preview.netlify.app |
Quick question, does the |
You need to specify it. For example |
…rs obtain more context about these steps.
gilesgas
reviewed
Jan 31, 2024
gilesgas
reviewed
May 16, 2024
gilesgas
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a known issue when using concurrency group with block/input steps.
The time-ordering of jobs that reference a concurrency is stable (roughly: the build creation time, and then the jobs ordering within that build). But only active jobs (roughly: running or eligible-to-run) are part of the queue. Jobs waiting for a block/input step aren’t active, so they’re not active in the queue, and so the concurrency group will let jobs from a newer build run. But then when you unblock that block/input step, those jobs become active in the queue, and potentially jump in front of the newer build, breaking the concurrency group ordering.