Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency group issues with block/input steps #2620

Merged
merged 9 commits into from
May 16, 2024

Conversation

pzeballos
Copy link
Contributor

There's a known issue when using concurrency group with block/input steps.

The time-ordering of jobs that reference a concurrency is stable (roughly: the build creation time, and then the jobs ordering within that build). But only active jobs (roughly: running or eligible-to-run) are part of the queue. Jobs waiting for a block/input step aren’t active, so they’re not active in the queue, and so the concurrency group will let jobs from a newer build run. But then when you unblock that block/input step, those jobs become active in the queue, and potentially jump in front of the newer build, breaking the concurrency group ordering.

There's a known issue when using concurrency group with block/input steps
@github-actions github-actions bot added the pipelines Pull requests that update content related to Pipelines label Jan 18, 2024
@buildkite-docs-bot
Copy link
Contributor

Preview URL: https://2620--bk-docs-preview.netlify.app

@gilesgas
Copy link
Contributor

gilesgas commented Jan 24, 2024

Quick question, does the concurrency attribute defined in a step specify the concurrency limit for that step?

@pzeballos
Copy link
Contributor Author

Quick question, does the concurrency attribute defined in a step specify the concurrency limit for that step?

You need to specify it. For example concurrency: 1 will set the limit to 1. If you don't put anything, it's like doing nothing :)

@pzeballos pzeballos requested a review from gilesgas as a code owner January 31, 2024 00:46
@gilesgas gilesgas merged commit 02fd5bf into main May 16, 2024
3 checks passed
@gilesgas gilesgas deleted the add-concurrency-group-caveats branch May 16, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines Pull requests that update content related to Pipelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants