Specified dependencies by default #2708
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivannalisetska
requested review from
mbelton-buildkite and
gilesgas
as code owners
github-actions
bot
added
the
pipelines
|
Preview URL: https://2708--bk-docs-preview.netlify.app |
gilesgas
reviewed
Mar 11, 2024
Comment on lines
6
to
+7
| > When all the steps in a build are skipped (either by using skip attribute or by using `if` condition), the build state will be marked as `not_run`. | ||
| > By default, all steps depend on the step that uploads them, and they will not run until that one is finished. |
There was a problem hiding this comment.
A couple of minor wording tweak suggestions, even though some of this content already existed...
Suggested change
| > When all the steps in a build are skipped (either by using skip attribute or by using `if` condition), the build state will be marked as `not_run`. | |
| > By default, all steps depend on the step that uploads them, and they will not run until that one is finished. | |
| > When all the steps in a build are skipped (either by using the skip attribute or by using the `if` condition), the build state will be marked as `not_run`. | |
| > By default, all steps depend on the step that uploads them, and they will not run until the uploading step is finished. |
When you said 'that one', were you referring to the uploading step?
If so, it'd be better to refer to 'that one' as 'the uploading step' to be clear what it is you're referring to as 'that one' is inherently a tad ambiguous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the sentence "By default, all steps depend on the step that uploads them, and they will not run until that one is finished" to clarify the default behaviour of synchronous execution, ensuring that users understand that steps are dependent on the completion of the preceding one and may need to adjust the async attribute accordingly for parallel processing in Buildkite. This aims to prevent confusion and provide a clear understanding of the execution flow.