Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pipelines product 'Service Quotas' page #2774

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Conversation

mitchbne
Copy link
Member

@mitchbne mitchbne commented May 1, 2024

In this PR we introduce a Service Quotas page for limits within the Pipelines product.

CleanShot 2024-09-03 at 14 30 00@2x

@github-actions github-actions bot added the pipelines Pull requests that update content related to Pipelines label May 1, 2024
@buildkite-docs-bot
Copy link
Contributor

Preview URL: https://2774--bk-docs-preview.netlify.app

@mitchbne mitchbne force-pushed the service-quotas branch 2 times, most recently from 2b1b7a1 to 016dbc3 Compare May 6, 2024 23:07
@mitchbne mitchbne marked this pull request as ready for review September 4, 2024 00:40
@mitchbne mitchbne requested a review from gilesgas as a code owner September 4, 2024 00:40
@mitchbne mitchbne requested a review from wolfeidau September 4, 2024 00:40
@mitchbne mitchbne self-assigned this Sep 4, 2024
@mitchbne mitchbne requested a review from dabarrell September 4, 2024 00:44
data/nav.yml Outdated
@@ -391,6 +391,8 @@
- name: "Cluster queue metrics"
path: "pipelines/cluster-queue-metrics"
pill: "beta"
- name: "Service Quotas"
path: "pipelines/service-quotas"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I note you've got this under Pipelines, but a handful of the limits are not pipelines-specific. I wonder if we need a global page? or just limit what's on this one to pipelines ones?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we do need a global page. At the moment, our navigation has:

Are you envisioning a new nav link?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need guidance from @gilesgas on that, but the content on this page atm doesn't really fit under pipelines

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are the docs for setting up organisations, teams, permissions etc?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content on this page atm doesn't really fit under pipelines.

Yeah, you're right. It feels like we're missing a concept of a global/cross-product area

Where are the docs for setting up organisations, teams, permissions etc?

At the moment those pages sit under the Pipelines navigation link - https://buildkite.com/docs/team-management/permissions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2024-09-04 at 11 32 35

Oh yeah, these are also definitely not pipelines haha

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, they're not 😅😅

{
title: "Invitations per organization",
description: "The maximum number of pending invitations for an organization",
default_value: "20 invitations"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another general thought – how do we keep these values synced with what's in bk/bk?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An assertion spec in bk/bk, with a link to this guide doc to update it if an engineer changes the default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be able to leverage some internal tooling options (e.g. https://github.com/danger/danger) to help us out here in the bk/bk side 👀

@gilesgas
Copy link
Contributor

gilesgas commented Oct 17, 2024

Hey @dabarrell and @mitchbne ,

Sorry it's taken me a while to revisit this PR, now that we have the new Platform area for the docs, I'm wondering if we could publish this work somewhere in here instead?

If so, I can fix this up for you...

@gilesgas gilesgas requested a review from a team as a code owner October 20, 2024 22:55
@buildkite-systems
Copy link

@github-actions github-actions bot removed the pipelines Pull requests that update content related to Pipelines label Oct 20, 2024
@buildkite-systems buildkite-systems merged commit 95fa925 into main Oct 22, 2024
2 of 3 checks passed
@buildkite-systems buildkite-systems deleted the service-quotas branch October 22, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants